- π§πͺBelgium tim-diels Belgium π§πͺ
This is applicable to 6.x. Patch works for 6.x also.
- π§πͺBelgium tim-diels Belgium π§πͺ
Hmm can't change the MR to a different branch. Maybe something only a maintainer can do?
- πͺπΈSpain enchufe Spain
Following recent changes, the MR as plain diff no longer functions as a patch. I include a backrroll to the previous changes as a patch.
- last update
almost 2 years ago 37 pass - Status changed to Needs work
11 months ago 11:44pm 10 April 2024 - πΊπΈUnited States smustgrave
Can we get test coverage for this change.
- πΊπΈUnited States smustgrave
We've now removed jquery so solution may need to be tweaked.
@smustgrave, I am probably seeing something wrong, but on 7.0.4, which at the moment is the latest 7.x tag, jQuery is used in the entire bef_sliders.js so I think this could go forward as is and refactored in another issue.
If you mean to rewrite the file to ditch jQuery, I would say that it is not in this issue's scope
Am I getting something wrong?
Also about the tests. ATM I see no test coverage on the sliders whatsoever. Could you be a bit more clear on what exactly we need from tests, so that I can maybe get to it? Thanks
- Merge request !138Places slider between min/max inputs (3214300). β (Merged) created by Marios Anagnostopoulos
Having said that, the patch did not work, even though it applied. ( I guess due to data selector naming changes) So I made a pr against 7.x and took some liberties changing the string concatenation to string literals.
The question about tests and jQuery still stand. Thank you
- πΊπΈUnited States smustgrave
Think we should least still contain it in the fieldset no?
- πΊπΈUnited States smustgrave
Want to get a beta 7.1.x release out and include this if possible