I started rerolling this for 1.0-alpha3 and found that the try block is overzealous. It only needs to capture an exception around
$location = $plugin->getParsedInput($this->value);
. Additionally since the catch block was doing the same thing as when $location is falsey, I've combined those two into one section. If we ever want different error messages then add the logic into the catch block in another patch.I share the thought that these messages should be customizable but I think that's out of scope of this issue at this point.
- Status changed to RTBC
about 2 years ago 11:04pm 22 February 2023 - πΊπΈUnited States mariacha1
This latest patch works great for me, and the code makes sense!
- Status changed to Fixed
about 2 years ago 1:21pm 23 February 2023 - π§πͺBelgium JeroenT π§πͺ
Committed and pushed to 8.x-1.x. Thanks!
Created β¨ Views filter: Make error message translatable when unable to geocode location Active as a follow-up
-
JeroenT β
committed 16ba62af on 8.x-1.x authored by
david.muffley β
Issue #3205987 by tim_dj, nikosnikos, david.muffley, alfattal,...
-
JeroenT β
committed 16ba62af on 8.x-1.x authored by
david.muffley β
Automatically closed - issue fixed for 2 weeks with no activity.