- Merge request !3Issue #3203383: Add support for search/replace in BlockContent (and other?) entities β (Open) created by chrisfromredfin
- πΊπΈUnited States philosurfer
#9 fails to patch the twig file, might need to be re-rolled.
- Applying patches for drupal/scanner patches/scanner_support-blocks-3203383-9.patch (add support for sar'ing blocks) patch '-p1' --no-backup-if-mismatch -d 'web/modules/contrib/scanner' < '/Users/marianocrivello/clones/pantheon/d8-ecompromotions/patches/scanner_support-blocks-3203383-9.patch' patching file 'src/Plugin/Scanner/BlockContent.php' patching file 'src/Plugin/Scanner/Node.php' patching file 'src/Plugin/Scanner/Paragraph.php' patching file 'templates/scanner-results.html.twig' 1 out of 1 hunks failed--saving rejects to 'templates/scanner-results.html.twig.rej' patch '-p0' --no-backup-if-mismatch -d 'web/modules/contrib/scanner' < '/Users/marianocrivello/clones/pantheon/d8-ecompromotions/patches/scanner_support-blocks-3203383-9.patch' patching file 'b/src/Plugin/Scanner/BlockContent.php'
- last update
over 1 year ago Patch Failed to Apply - π¨π¦Canada a.griff
Patch fixed from the latest updates. Should apply again.
- last update
over 1 year ago 3 pass - π§π·Brazil gedvan JoΓ£o Pessoa
#11 does not include #8 and #9 fixes. Here's a new one.
However, if the block is non-reusable (inline), the result's view/edit links point to an "access denied" page. In this case, it should point to the node containing the block. I'll try to implement this and submit a new patch.
- Status changed to Needs work
over 1 year ago 5:40pm 3 August 2023 - πΊπΈUnited States dcam
This needs an
accessCheck()
on the entity query in order to be compatible with Drupal 10. See π Fix access check on query (Drupal 10 compatibility) RTBC which adds it for the Node query.We're using this patch on a site that just got upgraded to D10 and scanner stopped working as a result of the lack of access checks in the scanner plugins.
- Status changed to Needs review
over 1 year ago 4:30am 4 August 2023 - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 3 pass - πΊπΈUnited States dcam
Sorry, I messed up when creating the patch in #14.
- Status changed to Needs work
over 1 year ago 5:34pm 8 August 2023 - πΊπΈUnited States dcam
The same change needs to be made to the replace() function. I'll try to come back to it again tonight.
- Status changed to Needs review
over 1 year ago 4:09am 9 August 2023 - last update
over 1 year ago 3 pass - πΊπΈUnited States dcam
I added the access check to the
request()
function. - last update
10 months ago 3 pass - First commit to issue fork.
- Status changed to Needs work
about 2 months ago 4:55pm 6 November 2024 - π©πͺGermany Anybody Porta Westfalica
I think to speed up the fix here, it would be great to:
- Revert changes on the other entity types and create a separate issue for these changes
- Only add Block content support here (which totally makes sense as core entity)
Then I think this should be close to RTBC! Could someone do that?
- πΊπΈUnited States smustgrave
Lets update for 2.0.x and add some test coverage please.