The views filter needs to have cacheability metadata applied when using Views caching

Created on 5 March 2021, over 3 years ago
Updated 14 February 2023, over 1 year ago

Problem/Motivation

We discussed this in private first and agreed to make it a public issue.

With views caching turned on, the Workbench access section fails to bubble cacheability metadata resulting in cache poisoning

Steps to reproduce

1. Enabling the module
2. Creating a view that lists content for users to edit
3. Create an access scheme using taxonomy
4. Add two terms (Sections) to the created vocabulary
5. Add the 'Workbench access section' filter to the view created earlier and ensure the view has caching enabled (tag based)
6. Create two editors, put one in each section
7. Create content in section one
8. Visit the listing page as user in section one and see your item listed
9. Visit the listing page as user in section two and you'll see the view that was rendered for the previous user (cached version)

Proposed resolution

Add a WBA cache context
Ensure the filter emits the correct cache metadata

Remaining tasks

All of the above

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

Live updates comments and jobs are added and updated live.
  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024