Conflict with Shortcut Menu module

Created on 23 February 2021, over 3 years ago

Updated 7 February 2023, over 1 year ago

Problem/Motivation

When using this module in combination with the Shortcut Menu module, error messages fill up the screen:
Notice: Undefined index: below in translatable_menu_link_uri_iterate_menu() (line 76 of modules/contrib/translatable_menu_link_uri/translatable_menu_link_uri.module).
This has to do with the Shortcuts menu links not having these keys.

Steps to reproduce

Install Shortcut Menu module
Build a menu of shortcuts (purpose of the module)
Install Translatable menu link uri
Receive mentioned errors

Proposed resolution

Add an better check in the function translatable_menu_link_uri_preprocess_menu to prevent this code form executing on links that don't have the requested parameters.

🐛 Bug report

Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇧🇪Belgium antoineh Mechelen, 🇧🇪

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇵🇱Poland jsobiecki Wroclaw
Hi @antoineh,

I believe this problem doesn't exist anymore on 2.x branch. Are you able to confirm it?
Status changed to Postponed: needs info over 1 year ago4:06pm 5 February 2023
Comment over 1 year ago →
🇵🇱Poland jsobiecki Wroclaw
Comment over 1 year ago →
🇧🇪Belgium flyke
I just had the same error using translatable_menu_link_uri 2.0.0 in a project when I switched from adminimal admin theme (+seeds_toolbar) to Gin theme as admin theme.

The patch from #4 still aplies and fixes the error.
Status changed to Closed: duplicate over 1 year ago1:22pm 7 February 2023
Comment over 1 year ago →
🇵🇹Portugal jcnventura
@jsobiecki is right. This is a duplicate of 🐛 Missing checks causing notices Fixed

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024