Missing checks causing notices

Created on 10 August 2021, over 3 years ago

Updated 29 January 2023, almost 2 years ago

Problem/Motivation

When certain values like 'below' are not set notices are thrown.
- Notice: Undefined index: below in translatable_menu_link_uri_iterate_menu()
- Notice: Undefined index: original_link in translatable_menu_link_uri_iterate_menu()
- Notice: Undefined variable: plugin_id in translatable_menu_link_uri_iterate_menu

Steps to reproduce

Create menu items without a sublevel.

Not having any items below the first will generate the first notice.
Original link can be empty so that can throw a notive.
If that happens $plugin_id is never set and has no default value which will throw another notice.

Proposed resolution

Perform checks and provide a default value where necessary.

I have attached a patch for this.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇱Netherlands thomasdik

Live updates comments and jobs are added and updated live.

ContributionWeekend2023

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇵🇱Poland jsobiecki Wroclaw
Hi, Im doing final review as part of Global Contribution Weekend.
Comment almost 2 years ago →
🇵🇱Poland jsobiecki Wroclaw
Comment almost 2 years ago →
System Message

jsobiecki → committed 822d9712 on 2.x authored by ThomasDik →
Issue #3227471 by ThomasDik, dermario, Anybody: Missing checks causing...
Status changed to Fixed almost 2 years ago3:22pm 29 January 2023
Comment almost 2 years ago →
🇵🇱Poland jsobiecki Wroclaw
Thanks all for contribution. I can confirm it works good. I decided to leave isset instead of empty.
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024