"drush node-access-rebuild-progressive" should not rebuild access grants if not needed

Created on 8 February 2021, almost 4 years ago
Updated 6 August 2024, 4 months ago

Problem/Motivation

drush node-access-rebuild-progressive always rebuild the access grants even if not needed.

Steps to reproduce

Run drush node-access-rebuild-progressive twice in a row.
It processes the same nodes each time.

Proposed resolution

The command should only do something if node_access_needs_rebuild() is true.

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡«πŸ‡·France prudloff Lille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡«πŸ‡·France prudloff Lille

    Well, this patch isn't having the module pick up where it left off in my case. I had a job die part way through (through no fault of this module)

    I also encountered this problem (Drush command crashing while processing nodes). Relaunching the Drush command will not process the remaining nodes, however it seems the cron will correctly pick up where drush stopped.

  • πŸ‡«πŸ‡·France prudloff Lille

    Here is a reroll for 2.0.1.

  • Status changed to Needs review 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States shelane
Production build 0.71.5 2024