Make the ordering of results configurable

Good feature. Needs reroll and check tests

@Bram can you review ad test?

Did a very quick review

Left some comments on the MR.

I've been thinking a bit about this feature. Wouldn't it be better to use a select list instead of a boolean value to orde by descending values? I can see a feature request coming to do the opposite of this ticket. Which would then probably introduce yet another checkbox.

Proposed select list values:
- By Weight (default)
- Alphabetical?
- By Votes Asc
- By Votes Desc
...

This would also make it easier to extend with more order/sorting logic, although I think the list is quite complete.

Also updated credits.

Hiding patches in favour of the merge request.

I added commit to MR with order type select. Please review, test and comment

I think some changes to the tests are also required

I think some changes to the tests are also required

Can you explain? Or do you want to fix it yourself?

The tests should check each of the options.

The tests should check each of the options.

It existing now

Default sort https://git.drupalcode.org/project/poll/-/merge_requests/41/diffs#f1854a...

Votes asc https://git.drupalcode.org/project/poll/-/merge_requests/41/diffs#f1854a...

Votes desc https://git.drupalcode.org/project/poll/-/merge_requests/41/diffs#f1854a...

Added two suggestions (readability mostly), and there is still one issue open one on the test

I think this is ok now. Will ask Berdir for a review as well.

@Berdir, can you review please?

Up!

Went ahead and merged this. If there would still be any feedback we can still fix it on the dev branch/new ticket.

Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.