- π©πͺGermany Anybody Porta Westfalica
@Neograph734 could you please reroll this as MR against 10.x?
- π¬π§United Kingdom aaron.ferris
aaron.ferris β made their first commit to this issueβs fork.
- π¬π§United Kingdom aaron.ferris
Hope im not stepping on anyones toes, but noticed some of these issues were quite old, so to keep them moving raised a quick MR - patch applied cleanly to 10.x.
- Status changed to Needs review
9 months ago 4:41pm 4 April 2024 - Status changed to RTBC
9 months ago 2:08am 5 April 2024 - π¦πΊAustralia elc
Curiosity - what's the reason for cloning request when getting the query parameters? Would it no be sufficient to clone the query parameters if they are an object, or if it returns an array that would be copied anyway? I'm expecting some pointed to wild kernel level explanation of avoiding bad outcomes :D Actually, it was done this way in both patches so you may not be in the know.
Otherwise the patch looks like it should do what it should.
- Status changed to Needs work
9 months ago 5:37am 5 April 2024 - π©πͺGermany Anybody Porta Westfalica
Yeah I also don't get the reason for the clone. We're just getting a value, don't we?
- π¬π§United Kingdom aaron.ferris
Yeah that did feel a little odd from the original patch, Iβll dig into it.
- Status changed to Closed: duplicate
9 months ago 6:56am 5 April 2024 - π©πͺGermany Anybody Porta Westfalica
This was already fixed as part of π Drupal 10 Readiness Fixed .
I removed the clone() method, it doesn't make any sense to me. If it's needed for any reasons, please teach me.