- last update
almost 2 years ago 29,394 pass, 1 fail - 🇮🇳India gauravvvv Delhi, India
I have addressed all the feedback from #55. I have added an interdiff as well as patch for same. please review.
- last update
almost 2 years ago 29,392 pass, 1 fail The last submitted patch, 58: 3182242-58.patch, failed testing. View results →
- last update
almost 2 years ago 29,398 pass - last update
almost 2 years ago 29,397 pass - last update
almost 2 years ago 29,397 pass - Status changed to RTBC
almost 2 years ago 10:55pm 29 May 2023 - last update
almost 2 years ago 29,401 pass - last update
almost 2 years ago 29,402 pass - last update
almost 2 years ago 29,411 pass 2:14 59:12 Running- last update
almost 2 years ago 29,428 pass - last update
almost 2 years ago 29,436 pass - last update
almost 2 years ago 29,435 pass, 2 fail The last submitted patch, 58: 3182242-58.patch, failed testing. View results →
- last update
almost 2 years ago 29,445 pass - last update
almost 2 years ago 29,450 pass - last update
almost 2 years ago 29,499 pass 47:14 13:48 Running- last update
almost 2 years ago 29,508 pass - last update
almost 2 years ago 29,553 pass - last update
almost 2 years ago 29,553 pass - last update
almost 2 years ago 29,559 pass - last update
almost 2 years ago 29,567 pass - last update
almost 2 years ago 29,571 pass - last update
almost 2 years ago 29,801 pass - last update
almost 2 years ago 29,801 pass - last update
almost 2 years ago 29,802 pass - last update
almost 2 years ago 29,804 pass - last update
almost 2 years ago 29,811 pass - Status changed to Needs work
almost 2 years ago 8:52am 12 July 2023 - 🇫🇮Finland lauriii Finland
-
+++ b/core/themes/olivero/css/components/page-error.pcss.css @@ -0,0 +1,42 @@ +.page-error-content__image--404 svg { ... +.page-error-content__image--403 svg {
Should we provide some attributes in the svgs that allow us to target them specifically?
-
+++ b/core/themes/olivero/images/403.svg @@ -0,0 +1,4 @@ +<svg xmlns="http://www.w3.org/2000/svg" width="602.4" height="283" viewBox="0 0 602.4 283" aria-labelledby="403Title 403Desc"> +++ b/core/themes/olivero/images/404.svg @@ -0,0 +1,4 @@ +<svg xmlns="http://www.w3.org/2000/svg" width="637.6" height="283" viewBox="0 0 637.6 283" aria-labelledby="404Title 404Desc">
Not sure what the
aria-labelledby
is intended to reference 🤔 -
+++ b/core/themes/olivero/olivero.theme @@ -607,6 +607,34 @@ function olivero_preprocess_table(&$variables) { +function olivero_preprocess_page(&$variables) {
What's happening in this preprocess seems almost too smart 😅 Wondering if this would be simpler if we just used the theme suggestions for 403 and 404?
-
+++ b/core/themes/olivero/olivero.theme @@ -607,6 +607,34 @@ function olivero_preprocess_table(&$variables) { + 'system.404' => t('Looks like we can’t seem to find what you’re looking for. Sorry about that!'),
I'm not sure we should be sorry if the page user was looking for was not found 🤔 That's also something that our interface text documentations advices us to avoid: https://www.drupal.org/docs/develop/user-interface-standards/interface-t... → .
-