Switching Slack.php properties from private to protected

Went ahead and made the properties protected to be inline with Drupal standards.

This is also a problem in 2.0.x with SlackSendRequest.php

In SlackSendRequest.php properties already protected.
There're only missing typehints, but it is another issue.
Can you provide some additional information?

$ grep -r private
src/Service/SlackSendRequest.php:  private function processMessage(string $message) {

In the fact, function processMessage is internal helper function which not used anywhere outside class and it is a reason to be private.
sendMessage function can overriden and don't need to use internal helper function in it.

If you don't think so then private modifier should be excluded from all OOP languages.

But it used in some other contrib modules.
For example in Config split module: \Drupal\config_split\ConfigSplitCliService::import

And I think function modifier shouldn't be changed.

Automatically closed - issue fixed for 2 weeks with no activity.