Remove @todo from file_save_upload()

This updates the @todo to point to this issue. Once this is committed, this issue can be changed to be about creating the service.

Not sure I see the benefit of updating a comment that this issue will be worked on, and working on it later.

But if we are just trying to update to a more relevant issue then a follow up should be opened to actually fix it and the comment pointed there.

I have created 📌 Convert file_save_upload() to a service Closed: outdated . This patch points to that issue.

LGTM

Thanks!

I think we should just remove the @todo altogether.

I'm OK with that, though having the @todo could save some time. A person sees this function, thinks it should be a service, and opens a ticket or do they see the @todo and visit the existing ticket? The cost of having the @todo is zero and there is a benefit.

Don't think I need the tests to finish to know this won't break anything.

I think the fact this issue is open with six people on it shows there was a cost to having the @todo. I think they're useful when an implementation has drawbacks but needs a stack of issues to improve, but not for saying procedural code should be OOP.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Adjusting title to match the work that was actually done.

Automatically closed - issue fixed for 2 weeks with no activity.