- 🇩🇪Germany andrerb
Re-roll patch
- Fix error for taxonomies
- update for D10 compatibility - last update
over 1 year ago Composer require failure - last update
over 1 year ago 8 pass - 🇩🇪Germany andrerb
Update D10 compatibility from #13
- remove obsolete "core: 8.x" from .info.yml - 🇩🇪Germany SteffenR Germany
I've updated the patch to work with latest 8.x-1.x-dev/ 8.x-1.7.
Unfortunately i cannot push to the existing Merge Request.
- 🇩🇪Germany SteffenR Germany
Updated patch, cause i missed a duplicate line..
- 🇩🇪Germany SteffenR Germany
Finally.. ;) Sorry for confusion in the last comment.
- 🇩🇪Germany SteffenR Germany
And another reroll, because the method entityIsPublishable was not working correctly, because the name of the module was passed to getDefinition instead of the bundle name.
@AndreRB: It would be great, if you could update the MR with the latest patch. 💚
- 🇩🇪Germany SteffenR Germany
The patch still had problems while translating entities, because the route object did not contain the _entity_form key.
I added an additional check for filled $form_arg and a logic to get the entity_type_id from the route object. - Status changed to Needs review
about 1 year ago 6:50am 10 October 2023 - First commit to issue fork.
- 🇩🇪Germany stborchert
Sorry, I f*d up MR5. Created a new branch: https://git.drupalcode.org/project/require_on_publish/-/merge_requests/15
Credits go to @AndreRB and @SteffenR
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
This doesn't seem to work for paragraphs which have been added to storage entities → , where storage entities are embedded using inline_entity_form. For that matter, it also doesn't work for any field added in a storage entity.
Maybe there's a way to make this work for more than just paragraph entities, like any entity which is embedded within the parent entity using inline_entity_form?
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
My previous comment may not apply actually., I had not set the entity reference field itself to require on publish, after doing that things seem to be working better, but I need to do some testing tomorrow.
- First commit to issue fork.
- 🇩🇪Germany stborchert
@TejaVardhanReddy Patches are always created to the development branch, not existing releases. 8.x-1.0 is already released and cannot be changed anymore.
Additionally, when providing a patch, please add an interdiff → , so reviewers can see what has changed since the last patch. - 🇺🇸United States markdorison
Please ensure that the lastest changes are included in a merge request so that tests can be run. Tests are no longer run on patches since we have switched to GitLabCI → .