Add require on publish as a conditional field option

I've pushed a couple of commits to the fork (noting here in case someone overrides):

• 7c81d5ec
• a7c9c47d

I am still working through some issues:

1. I think I need to prevent error message removal when the condition is not met in \Drupal\conditional_fields\ConditionalFieldsFormHelper::formValidate().
2. It seems the dependentValidate() thinks the condition is "triggered" when it is not.
3. The dependentValidate() also seems to be explicitly handling required and !required.
4. Not yet sure if it is best to pass the _wrapper in the error key.

Fork description

So that the module doesn't depend on Conditional Fields, the logic is provided in a submodule. When enabled, it provides require_on_publish as one of the possible #states.

Steps to reproduce

Using the provided fork, you may begin to understand how this might work.

1. Install Require on Publish and Conditional Fields.
2. Add a boolean field to Basic Page, and a text field.
3. Under Structure > Conditional Fields, make the text field required on publish when the boolean field is checked.
4. Create a Basic Page.

With the above and the branch as it stands, the required on publish markings are successfully applied. However, the error handling still needs work.

Problems persist

See comment above and comments in code for an understanding of the ongoing problems.

By adding full support for #states Form API conditions, integration with Conditional Fields → is possible with:

use Drupal\Core\Form\FormStateInterface;

/**
 * Implements hook_conditionalFieldsStates_alter().
 *
 * @see Drupal\conditional_fields\Conditions::conditionalFieldsState
 * @phpcs:disable Drupal.NamingConventions.ValidFunctionName.InvalidName
 */
function require_on_publish_conditional_conditionalFieldsStates_alter(array &$states) {
  // phpcs:enable
  // A list of supported states that may be applied to a conditional field.
  $states['require_on_publish'] = t('Required on Publish');
}

Rolled MR !24 into a stable patch file.

Let's limit the lint fixes to the changed or newly introduced files, please.

The following already exist to fix the lint failures:

• 🐛 Fix spelling errors Active
• 🐛 Fix eslint issues Active

This last commit introduced new lint errors; perhaps used the wrong eslint settings.

If you revert ecb04525 - fixed eslint issues, you will only need to address the following:

/builds/issue/require_on_publish-3530547/web/modules/custom/require_on_publish-3530547/js/states.js
   8:15  error  Identifier 'legend_span' is not in camel case  camelcase
  23:13  error  Identifier 'legend_span' is not in camel case  camelcase
  34:13  error  Identifier 'legend_span' is not in camel case  camelcase

We're getting closer to a proper roadmap. I have placed this in the queue for 2.1.0.

Updated the patch to limit ESLint fixes to only the files changed in this issue.

Needs test coverage.

Added tests. Tests pass, but since the PHPUnit update bug they fail.

Needs review.

Automatically closed - issue fixed for 2 weeks with no activity.