Remove commit author radios in the "Credit & committing" section.

Created on 15 October 2020, over 3 years ago
Updated 16 April 2024, 2 months ago

Problem/Motivation

The Credit & Committing fieldset currently has an β€œAuthor” element which changes the --author argument for the commit command template. GitLab does not currently have a way to set the author on squash merge commits. When https://gitlab.com/gitlab-org/gitlab/-/issues/26902 is resolved, we can use it.

(There is an sudo option in the API to make the merge commit as another user, but they need to be a maintainer of the project. We could temporarily make the author a maintainer. We have integrity checking that looks for mis-synced maintains, but that’s still too close to allowing unauthorized pushes.)

OR, --author is not used on many projects, notably Drupal core, since selecting a single primary author is not always doable. We could remove the β€œAuthor” element. To help make this decision, we can query for commits where author != committer to show how widely this is used.

Steps to reproduce

Select a radio button for an author, click Merge. (When the Merge button exists #3072047: Handle merging of merge requests β†’ )

Proposed resolution

Remove commit author selection. Merges will be done as GitLab does them, authored by the merge request creator. Command-line commits will no longer have the author suggestion

Remaining tasks

User interface changes

The β€œAuthor” radio buttons to set commit authorship may be removed.

πŸ“Œ Task
Status

Fixed

Version

3.0

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024