Language cache context should be passed to the block

Whao crazy, it looks like it causes this effect for us: 🐛 URL language detection with empty path prefix not working Needs work

We're using content language and saw translated custom menu items appearing in the wrong language as anonymous user (only). After clearing cache the correct menu links in the current content language appear!

That smells like a cache context issue?

Regarding the patch implementation: I'm unsure if that's not something that should already be added in the parent level?

Maybe in SystemMenuBlock? Or is it something that would have to be added by content_translation module?

Do we know anyone who can tell that easily?

Also see 🐛 Untranslated menu items are displayed in menus Needs work for some slightly related issues...

I guess this will help with debugging: [#3162480]

Update concerning @Anybody's comments here. The issue was solely fixed through using the patch in 🐛 URL language detection with empty path prefix not working Needs work .

The patch provided here, seems to not be needed anymore. I could imagine, that the "languages:language_content" cache context is already added through some event handler anyway, but please test it for yourself first!

Setting this postponed for now, until others confirm our observations.