Discuss use of named arguments in Renderer::doCallback()

Created on 30 September 2020, about 4 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

To make core compatible with PHP 8 #3174022: call_user_func_array() and named arguments in PHP 8 β†’ arguments passed to trusted callback are limited by array_values() for $args array.
But render callbacks could benefit using https://wiki.php.net/rfc/named_params

Steps to reproduce

See usage of \Drupal\Core\Render\Renderer::doCallback() and \Drupal\Core\Security\DoTrustedCallbackTrait::doTrustedCallback()

Proposed resolution

TBD

Remaining tasks

- discuss and create patch
- remove todo from \Drupal\Core\Security\DoTrustedCallbackTrait::doTrustedCallback()

User interface changes

no

API changes

TBD

Data model changes

no

Release notes snippet

TBD

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
RenderΒ  β†’

Last updated about 8 hours ago

Created by

πŸ‡«πŸ‡·France andypost

Live updates comments and jobs are added and updated live.
  • PHP 8.0

    The issue particularly affects sites running on PHP version 8.0.0 or later.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024