The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 12:26pm 3 February 2023 - 🇮🇳India mohit_aghera Rajkot
- Update the PR with latest 10.1.x and resolve merge conflicts.
- Change the destination branch. - Status changed to RTBC
almost 2 years ago 4:44pm 1 March 2023 - 🇺🇸United States smustgrave
Change looks good to me. Only question I'll have for the committer is if the test module should go into dblog?
- Status changed to Fixed
almost 2 years ago 11:39am 3 March 2023 - 🇬🇧United Kingdom catch
I thought about #24, and eventually came to the conclusion that a test module + extra test for this one-line fix to an error message isn't necessary - it's code that needs to be maintained over time as well. So I've gone ahead and committed the fix, but left the test coverage out of the commit. Would have been good to have come to this realisation earlier to avoid doing the work to add the test in the first place, but we are still figuring out 🌱 [policy, no patch] Better scoping for bug fix test coverage RTBC as we go along.
Committed bf064d2 and pushed to 10.1.x. Thanks! Also cherry-picked to 10.0.x and 9.5.x
Realised the title was outdated when discussing this issue with @alexpott, however I also forgot to change it before commit, changing it here though.
Automatically closed - issue fixed for 2 weeks with no activity.