- 🇺🇸United States mariacha1
I definitely don't fully grasp what changes would be needed to this PR to get it to work with https://www.drupal.org/project/commerce/issues/3047103 → , but this small addition to #55 does allow you to add a payment method to an order that's in the "needs_payment" state when you visit, for example,
/user/[UserId]/orders/[OrderId]/payment-retry
.I'm kind of hard-coding the workflow, though, and that's probably not right. If anyone can point me in the proper direction, I'm happy to make more changes.
- Status changed to Needs review
about 1 year ago 5:17pm 13 September 2023 - last update
about 1 year ago run-tests.sh fatal error - 🇺🇸United States mariacha1
Here are a few more changes to make this new page easier to get to.
Change 1: Link the email telling you a payment was rejected to this new page to fix it.
Change 2: Add an action button to the order page so if your order is in "needs payment" state, you can fix the payment right from the order page. - last update
11 months ago run-tests.sh fatal error - 🇺🇸United States SocialNicheGuru
does not work with Drupal 10. the patch introduces drupal_get_path
- last update
10 months ago 8 pass, 44 fail - 🇺🇸United States SocialNicheGuru
Updated patch and replaced drupal_get_path, [#2940438]
The last submitted patch, 62: commerce_recurring-retry-payments-3172234-61.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇺🇸United States SocialNicheGuru
Do not use last patch. several additions from 60 missing.
I had to git add the specific files then git diff HEAD > patch-name - last update
10 months ago run-tests.sh fatal error - last update
10 months ago run-tests.sh fatal error josephr5000 → made their first commit to this issue’s fork.
The initial route has a /user/{user} prefix whereas subsequent routes in the checkout flow lack that. This makes it harder than necessary to theme for consistent and trustworthy UX appearance throughout this flow. It seems preferable to work with the order's customer instead of obtaining the $user from the route, making it unnecessary to have the /user/{user} prefix.
I'd appreciate others checking to be sure you agree that working with the order's customer is a valid thing to do here!
This patch removes the /user/{user} route prefix and makes some consequential adjustments.
NOTE: this patch is based on #60 as I couldn't get #64 to apply cleanly to 8.x-1.x-dev. Happy to re-roll if @SocialNicheGuru can help me out.
Patch 66 changes the payment retry route, but for a transitional period there may be Dunning emails in customer inboxes that still point to the old (deprecated) route. Here's a utility module I'm using to bridge the gap, in case anyone else finds it helpful.
- last update
10 months ago run-tests.sh fatal error - Merge request !25Make retry route consistent. Eases theming. Better UX. → (Open) created by josephr5000@yahoo.com
- last update
9 months ago run-tests.sh fatal error josephr5000 → changed the visibility of the branch 3172234-patch-66 to hidden.
josephr5000 → changed the visibility of the branch 3172234-patch-60-plus to hidden.
josephr5000 → changed the visibility of the branch 3172234-allow-to-retry to hidden.
Changes:
- I recovered @SocialNicheGuru's change
- Created a merge request from the issue fork
- Attached patch #68 for your convenienceAdvance apologies that my branch name might not have been the best choice. If anyone wants to rename it, feel free.
- Status changed to Needs review
4 months ago 11:49am 23 July 2024 - 🇺🇸United States SocialNicheGuru
I noticed that there was hook_install but no corresponding hook_update. I added it to this patch.
- 🇺🇸United States SocialNicheGuru
Please disregard the last two. Several files were missing.
Please use this one
- 🇺🇸United States SocialNicheGuru
Rerolled because of conflict with commit 🐛 Customer Subscription list view is broken in 10.3 Fixed
- First commit to issue fork.
- 🇺🇦Ukraine AstonVictor
replaced
use Symfony\Component\EventDispatcher\Event;
withuse Drupal\Component\EventDispatcher\Event;