Allow off_session payment intents for recurring payments

Re-rolled the patch against dev branch

The last submitted patch, 64: commerce_stripe-off-session-payments-3171408-64.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

@jsacksick committed the blocker ✨ Allow for payments without stripe review pane Fixed .
With a reroll, tests should pass and this should be RTBC.

Will attempt a reroll.

@riabovol: Regarding the MRs from #61-63, I don't see @Bojan's comments anywhere in this thread.

Let's see how this goes.

The last submitted patch, 69: commerce_stripe-off-session-payments-3171408-69.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Hmm. Think I rerolled based on the wrong patch, it should be #54. MR18 is unrelated, and not sure about MR17. This is a mess to follow. Revisiting.

This patch should pass, it does locally.

One addition to PaymentIntentTest::testCreatePaymentIntent() - if we are testing the dataset with a passed-in payment generated, the payment needs to return a valid Price for PaymentInterface::getAmount(), to avoid a MinorUnitsConverter::toMinorUnits() error.

Thanks @John!

I've been trying to get commerce_stripe going with recurring payments for a few weeks now while in Stripe test mode.
commerce_recurring 8.x-1.0-rc1
commerce_stripe 8.x-1.0-rc8
commerce_license 8.x-2.0-beta2

I've applied the patch at #72 and set my future usage to off session in the Stripe Review pane. I still get a fail on the first recurring attempt.

RuntimeException: Failed to start the session because headers have already been sent by "/vendor/symfony/http-foundation/Response.php" at line 1239. in Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage->start() (line 152 of /vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php).

This is different from the one I got prior to the patch, which was:

/html/core/modules/big_pipe/src/Render/BigPipe.php" at line 264. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of /html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php)

Will keep testing and see what I come up with.

@kent@passingphase.nz - If you remove commerce_license do recurring payments work? Are any other patches applied against commerce, commerce_recurring or commerce_stripe?

Commerce license is an essential part of the recurring payment existence, in that these are subscriptions, for which is a license is assigned. If I have no luck I will try removing commerce license as a test.

The only other patch applied is to commerce, as follows: https://www.drupal.org/files/issues/2021-05-12/commerce-send_mail_after_... → , which involves sending an email when purchasing and registering at the same time.

Hm. How is cron being triggered? The built-in automatic cron, or an external cron run? So we don't junk up this RTBC issue any further, maybe this warrants a separate issue, probably in either commerce_recurring or commerce_license.

Thanks, @John Pitcairn. I'll try running cron from crontab, and post this issue on a suitable module elsewhere.

Automatically closed - issue fixed for 2 weeks with no activity.