- 🇨🇦Canada joseph.olstad
New version of patch 4 which is now compatible with PHP 8.0
also providing interdiff between patch 4 and patch 8.
- Assigned to joseph.olstad
- Status changed to Active
almost 2 years ago 1:10am 22 February 2023 - Issue was unassigned.
- Status changed to Closed: won't fix
almost 2 years ago 1:35am 22 February 2023 - 🇨🇦Canada joseph.olstad
new patch 10, works well, fixes some other critical bug we noticed so far.
adding better_exposed_filters and drupal 10 support to composer.json
new interdiff from 4 to 10
new patch 10, ignore 8
- Assigned to joseph.olstad
- Status changed to Active
almost 2 years ago 2:17am 22 February 2023 - 🇨🇦Canada joseph.olstad
This is an interesting patch, our initial tests show very good results with PHP 8.0 and Drupal core 9.5.3 using auctions dev branch and patch 10 without any other patches.
- 🇨🇦Canada joseph.olstad
ok we needed 3316118_deprecated fix in here also 🐛 Automatic conversion of false to array is deprecated in Drupal\auctions_core\Plugin\Block\AuctionItemCountdown::build() Fixed
figured I'd do a rollup of all the PHP 8 fixes , this should do it. - 🇨🇦Canada joseph.olstad
hmm, for the patch in #12
this change seen in the interdiff was probably a mistake
Should probably go back and retest patch 12 but remove this part of the patch.
diff --git a/auctions.links.action.yml b/auctions.links.action.yml index 781775a..aca3e31 100644 --- a/auctions.links.action.yml +++ b/auctions.links.action.yml @@ -11,16 +11,4 @@ auctions.finished: appears_on: - view.auctions.active - view.auctions.finished -auctions.active: - route_name: view.auctions.active - title: 'Active Auctions' - appears_on: - - view.auctions.active - - view.auctions.finished -auctions.finished: - route_name: view.auctions.finished - title: 'Finished Auctions' - appears_on: - - view.auctions.active - - view.auctions.finished
so a new patch that does not remove these entries in the action
- Assigned to SKAUGHT
- 🇨🇦Canada SKAUGHT
This work added by lillian was actually project specific (should have been in project patch, not contrib). needs that cleaned out.. some of the mail fixes should remain. i'll clean this up.
- Status changed to Fixed
about 1 year ago 4:55pm 1 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.