- ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
Patch #10 fixes the issue for me.
- Merge request !54Issue #3159890: Fix BEF filter field ordering โ (Merged) created by gaurav_manerkar
- Status changed to Needs review
6 months ago 10:55am 8 March 2024 - ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
Patch doesn't apply to 6.x branch
Prepared MR - https://git.drupalcode.org/project/better_exposed_filters/-/merge_reques... from patch #10.
Please review. - Status changed to Needs work
5 months ago 12:28am 11 April 2024 -
smustgrave โ
committed 035e8329 on 6.0.x authored by
gaurav_manerkar โ
Issue #3159890: Fix BEF filter field ordering
-
smustgrave โ
committed 035e8329 on 6.0.x authored by
gaurav_manerkar โ
- Status changed to Fixed
5 months ago 2:45pm 11 April 2024 - Status changed to Needs work
5 months ago 12:41am 12 April 2024 - ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
@smustgrave pls give credits.
Thanks. - Status changed to Fixed
5 months ago 1:03am 12 April 2024 - ๐บ๐ธUnited States smustgrave
Can you provide what you did? From what I can tell the MR started was the same as patch #10 which applied cleanly at the time.
- ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
Hi,
I had re-rolled the patch and had tested the original fix. - ๐บ๐ธUnited States smustgrave
So for me the patch had applied fine.
When posting a reroll itโs good to post in a comment from your terminal how it no longer applies. Like error at file xyz
When doing tests it should be noted what you did. Core version, steps, etc. Saying looks good is usually not enough.
If the issue was triaged at all, like more information request or gathered, tests requested, issue summary cleanup, that would have been good too.
If looking for a testing credit would go over to https://www.drupal.org/project/better_exposed_filters/issues/3440276 ๐ Testing needed Active and see if there is a scenario not already covered and post steps there. Keeping that open for a week
Thanks
- ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
The credit should be given to all users who assisted in the development or testing of the bug / provided a fix. That is how it works in Drupal community.
Credit should be given for non-code contribution as well but looks like you have your own rules of giving the credits.
I don't understand your point of having separate issue ( https://www.drupal.org/project/better_exposed_filters/issues/3440276 ๐ Testing needed Active ) for conducting the module testing.
Thanks.
- ๐บ๐ธUnited States smustgrave
Sorry you feel that way but I follow the same rules that we use on core.
The testing ticket is to help get ready for the next release and get people involved. If not interested thatโs fine.
Iโm going to consider this issue resolved
Thanks
Automatically closed - issue fixed for 2 weeks with no activity.