Use standard SQL (not MySQL-specific extensions) for database support

Created on 6 July 2020, almost 4 years ago

Updated 13 June 2024, 14 days ago

Currently the Download Count module uses various MySQL-specific functions (eg FROM_UNIXTIME()) in its queries to group by date etc.

These aren't necessary to function correctly, and break the module for non-MySQL DBs. When Download Count is installed on Postgres or SQLite, the exceptions thrown from failed DB queries will prevent other module crons running too.

Use of engine-specific SQL syntax is (AIUI) discouraged in Drupal contrib. Best docs links I could find at time of writing:

🐛 Bug report

Status

RTBC

Version

1.0

Component

Code

Created by

🇳🇿New Zealand xurizaemon Ōtepoti, Aotearoa 🏝

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 6 months ago →
🇳🇿New Zealand amanp Poneke
Re-roll #5 🐛 Support for non-MySQL DBs Needs review to be compatible with #3296984 Update module to be D10 compatible.
Comment 6 months ago →
🇳🇿New Zealand xurizaemon Ōtepoti, Aotearoa 🏝
Thanks for the re-roll Aman! Updating description with some links to why MySQLisms are discouraged.
Comment 6 months ago →
🇳🇿New Zealand xurizaemon Ōtepoti, Aotearoa 🏝
Status changed to RTBC 14 days ago10:34pm 13 June 2024
Comment 14 days ago →
🇳🇿New Zealand ericgsmith
Looks good to me - we (note - I am a colleague of xurizaemon and amanp) have been using this patch on a site with postgres for several years.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024