- 🇦🇺Australia acbramley
I think we need a slightly better name for the setting, I'm also questioning whether we really need all the plumbing for a config screen with a single checkbox on it. It could just be a hidden (and documented) config setting.
We also need an update hook to set the value for existing sites.
- Status changed to Needs review
over 1 year ago 10:08am 20 February 2023 - 🇧🇪Belgium dieterholvoet Brussels
I think it's a pretty essential feature, so the setting should definitely be exposed in the UI. The plumbing is just necessary because this module doesn't have a settings form yet, I'm sure more settings will be added at some point in the future.
I renamed the config option to
settings_route_admin_theme
and improved the description a little bit. - Status changed to Needs work
over 1 year ago 9:28pm 20 February 2023 - 🇦🇺Australia nterbogt
I don't believe this needs to be optional / opt-in. I think it's clear it should be an admin route, next to 'View', 'Edit', 'Delete', 'Revisions', etc. I'm not sure there is any UX benefit to using the page theme and having it inconsistent with everything else.
It's also a duplicate of 🐛 The generate-preview-link page renders in the site's theme RTBC , which I know was created after. But might be easier to push the individual changes through rather than globbing them together.
- Status changed to Closed: duplicate
about 1 year ago 3:49am 31 October 2023 - 🇦🇺Australia acbramley
Closing as a dupe of 🐛 The generate-preview-link page renders in the site's theme RTBC however, I will transfer credit for those who worked on this issue. Thanks!