Add option for Preview Link generate route to render in admin theme

Created on 6 July 2020, about 4 years ago
Updated 31 October 2023, 11 months ago

Add a config option to opt-in the generate form into rendering in the admin theme by marking the route as admin

Feature request
Status

Closed: duplicate

Version

2.1

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇦🇺Australia acbramley

    I think we need a slightly better name for the setting, I'm also questioning whether we really need all the plumbing for a config screen with a single checkbox on it. It could just be a hidden (and documented) config setting.

    We also need an update hook to set the value for existing sites.

  • Status changed to Needs review over 1 year ago
  • 🇧🇪Belgium dieterholvoet Brussels

    I think it's a pretty essential feature, so the setting should definitely be exposed in the UI. The plumbing is just necessary because this module doesn't have a settings form yet, I'm sure more settings will be added at some point in the future.

    I renamed the config option to settings_route_admin_theme and improved the description a little bit.

  • Status changed to Needs work over 1 year ago
  • 🇦🇺Australia acbramley

    If we're going to go down this route then we need tests for the new settings page and coverage for submitting the form rebuilding the route (i.e load generate page, check not admin theme, submit form, check admin theme on generate route).

    Also need update hook as per #13

  • 🇦🇺Australia nterbogt

    I don't believe this needs to be optional / opt-in. I think it's clear it should be an admin route, next to 'View', 'Edit', 'Delete', 'Revisions', etc. I'm not sure there is any UX benefit to using the page theme and having it inconsistent with everything else.

    It's also a duplicate of 🐛 The generate-preview-link page renders in the site's theme RTBC , which I know was created after. But might be easier to push the individual changes through rather than globbing them together.

  • Status changed to Closed: duplicate 11 months ago
  • 🇦🇺Australia acbramley

    Closing as a dupe of 🐛 The generate-preview-link page renders in the site's theme RTBC however, I will transfer credit for those who worked on this issue. Thanks!

Production build 0.71.5 2024