Add cache-tag prefix

We need to use this patch and I thought I'd update it to address the issues raised.

For the test I have just added the with prefix case in a second assert in the existing formatTest() in CacheTagFormatterTest.php, the pre-existing test already covers not using a prefix. I can separate this out to a second set of tests though if this is not the right way to do it.

it will not let me add tests against anything but 7.x-2.x :(

If you could please correct this:
'#title' => t('Cache Tag Prefix'),

Which should be using $this->t()), I'll see about merging this tomorrow.

here you go

That's great, thank you very much.

@pobster

Shouldn't this be committed to the 5.x branch as well?

I have no idea why the 5.x branch exists. There's been no communication about it, as far as I'm concerned it's a fork and I have no clue what the intention is for it. In which case, you'll need to raise a separate issue for 5.x - note that the patch here broke another test, so when you make another patch, please be sure to add the fix I made too.

moshe weitzman → made their first commit to this issue’s fork.

The 5.x branch provides Drupal 10 compat. We were unable to find a way to do that in the 4.x branch because of dependency hell between D9, D10 and PHP. See 📌 Drupal 10 compatibility Fixed . If you can find a way in 4.x, we can delete the 5.x branch.

I suggest asking a question when you dont know something. It can be quite alarming for users when a maintainer claims that a supported release is in fact a fork within the official repo. I dont think bringing D10 compat qualifies as a fork.

Hmmmm maybe I phrased it badly, but I really just meant to say that I had no idea what the purpose of the 5.x branch is - and that I'm not aware of any roadmap issue ticket existing to explain why it exists. As in, this view doesn't help with that: https://www.drupal.org/project/issues/akamai?text=&status=All&priorities... →

In my view, changing to a branch new major release version is for a rewrite. But sure, it could also be for D10 compatibility - I just didn't immediately see any information about it really to know whether the patch created here was even applicable.

Automatically closed - issue fixed for 2 weeks with no activity.