- Status changed to Needs work
over 2 years ago 5:52pm 16 January 2023 - Status changed to Postponed: needs info
5 months ago 10:49pm 20 March 2025 - π¦πΊAustralia acbramley
I'm not so sure we should do this, once we swap to the generic revision UI in π Switch Node revision UI to generic UI Needs review this would no longer work and I'm not entirely sure it's necessary to override the title in this way.
Further, the current solution changes both the page title and the title in the rendered content, making for a bit of a weird display.
- πΊπΈUnited States smustgrave
Just wanted to give this one more bump if something we want to do? If no response could close out in 3 months.
- π¦πΊAustralia acbramley
Let's just rescope this to removing the title callback entirely. This is a controller so not covered by BC policy.
- Merge request !12711Issue #3154069: Remove NodeController::revisionPageTitle β (Open) created by acbramley
- πΊπΈUnited States smustgrave
Makes sense to me! Thanks for re-scoping this one.
- π¬π§United Kingdom catch
I think it's fine to directly remove the method here especially given it's not even called by core. If someone had subclassed the controller and overridden the title callback to use elsewhere (even this seems unlikely), their title callback will be used in that context anyway. There is absolutely no reason for the method to be called from any other context.