Contrib.social

Node revision view page title no longer displays custom title with date

Open on Drupal.org →
Created on 23 June 2020, almost 5 years ago
Updated 16 January 2023, about 2 years ago

Problem/Motivation

Discovered this as a part of reviewing #2730631-107: Upcast node and node_revision parameters of node revision routes → , where use of a removed function did not expose lack of coverage.

\Drupal\node\Controller\NodeController::revisionPageTitle is no longer called or has test coverage.

Currently, when a node revision is rendered by entity.node.revision route, the label of the revision is output. However a title callback (\Drupal\node\Controller\NodeController::revisionPageTitle) exists to change the page title to Revision of %title from %date.

Cause

Since #2498849: Entity view controller title rendering is expensive → was committed, a pre-render callback was to compute the title for entities being rendered. Once the callback (\Drupal\Core\Entity\Controller\EntityViewController::buildTitle) runs, a #title key is added to the render array. Because the key exists, the title callback for entity.node.revision is no longer executed by $get_title anonymous function in \Drupal\Core\Render\MainContent\HtmlRenderer::prepare.

Steps to reproduce

- go to /node/add/article and create a article
- edit this article
- check the revision created, if it's your first article (fresh installation) you can check it in /node/1/revisions/1/view

Proposed resolution

Add $node_revision->setTitle($this->revisionPageTitle($node_revision)); in ../core/modules/node/src/Controller/NodeController::revisionShow.

Remaining tasks

Code review

User interface changes

Existing UI:

Proposed UI:

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

RTBC

Version

10.1 ✨

Component
Node system  →

Last updated about 11 hours ago

No maintainer
Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work about 2 years ago
  • Status changed to Postponed: needs info 15 days ago
  • Comment 15 days ago →
    🇦🇺Australia acbramley

    I'm not so sure we should do this, once we swap to the generic revision UI in 📌 Switch Node revision UI to generic UI Needs review this would no longer work and I'm not entirely sure it's necessary to override the title in this way.

    Further, the current solution changes both the page title and the title in the rendered content, making for a bit of a weird display.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024