- 🇦🇺Australia jaydee1818 Melbourne
I've re-written the JS for this module to modernise and improve it. The main changes are:
- Use modern Vanilla JS and remove jQuery
- Use the once library to prevent multiple loads
- Add accordion code to Drupal.behaviors
- Status changed to Needs review
over 1 year ago 6:07am 26 July 2023 - last update
over 1 year ago 191 pass, 5 fail The last submitted patch, 2: update-js-examples-to-vanilla-js-3153485.patch, failed testing. View results →
- last update
over 1 year ago 191 pass, 5 fail - 🇦🇺Australia jaydee1818 Melbourne
This patch actually removes the jQuery lib from the .libraries file. Disregard first patch.
The last submitted patch, 6: update-js-examples-to-vanilla-js-3153485.patch, failed testing. View results →
- Status changed to Active
over 1 year ago 8:19am 26 July 2023 - 🇦🇺Australia jaydee1818 Melbourne
Tests are failing here due to issue here: https://www.drupal.org/project/examples/issues/3376999 🐛 Field Example Add Field text outdated in Functional tests in D10.1 Needs review
- First commit to issue fork.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3153485-js-example-enhancement to hidden.
- Merge request !75Issue #3153485: Rewrite the JavaScript code to use behaviors and plain JavaScript → (Merged) created by apaderno
- Status changed to Needs review
5 months ago 4:47pm 11 July 2024 -
apaderno →
committed 2829ad83 on 4.0.x
Issue #3153485: Rewrite the JavaScript code to use behaviors and plain...
-
apaderno →
committed 2829ad83 on 4.0.x
- Status changed to Fixed
5 months ago 4:54pm 11 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.