Contrib.social

Project Update Bot generates patch based on .info.yml in tarball

Open on Drupal.org →
Created on 7 June 2020, about 5 years ago
Updated 18 March 2024, over 1 year ago

Problem/Motivation

The bot generated #3148516: Automated Drupal 9 compatibility fixes → with a patch including this hunk for the .info.yml file:

diff --git a/ptoc.info.yml b/ptoc.info.yml
index 6a2e8e2..c9880b5 100644
--- a/ptoc.info.yml
+++ b/ptoc.info.yml
@@ -22,5 +22,6 @@ dependencies:
 # Information added by Drupal.org packaging script on 2017-04-16
 version: '8.x-1.0'
 core: '8.x'
+core_version_requirement: ^8 || ^9
 project: 'ptoc'
 datestamp: 1492375445

That hunk does not apply to the .info.yml file in the git branch. I did not confirm, but I assume it applies to the version of the file included in the tarball.

Proposed resolution

Generate a patch that applies to the .info.yml file in the repository.

There might be easier work-arounds, but one option is to remove the problematic hunk from the patch, then make the corresponding changes manually.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

🐛 Bug report
Status

Fixed

Component

Code

Created by

🇺🇸United States benjifisher Boston area

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇭🇺Hungary Gábor Hojtsy Hungary

    Moving to project analysis where the code lives now.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇳🇱Netherlands bbrala Netherlands

    The bot has been adjusted to use get from source, this means we should not have the problem anymore with the added info from the composer endpoint and such. So this has been fixed afaik.

    Process is now:

    1. Analyse with composer --prefer-source which clones a git repo.
    2. Info changes should now also not contain garbage from the compose endpoint
    3. Patches are applies to a git checkout in the bot.
    4. Pushed to branch and MR opened against a dev branch based on the version

    I think this is now a non issue for d11 readiness.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024