Fix code standards errors 8.x-3.x

Created on 29 May 2020, over 4 years ago
Updated 3 December 2024, 2 months ago
πŸ“Œ Task
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States andileco

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9
  • πŸ‡ΊπŸ‡ΈUnited States andileco

    @bluegeek, I see this as "Needs review", but I'm not seeing any changes in the "3144014-fix-code-standards" branch.

  • Pipeline finished with Success
    2 months ago
    Total: 141s
    #358159
  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9
  • Pipeline finished with Success
    2 months ago
    Total: 141s
    #358180
  • Pipeline finished with Success
    2 months ago
    #358186
  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9

    I left these four issues. All the changes in the pull request are whitespace changes.

    FILE: /var/www/html/web/modules/custom/charts/modules/charts_chartjs/src/Settings/Chartjs/ChartjsScales.php
    ------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------------------
     32 | ERROR | Public method name "ChartjsScales::getXAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
     42 | ERROR | Public method name "ChartjsScales::setXAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
     52 | ERROR | Public method name "ChartjsScales::getYAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
     62 | ERROR | Public method name "ChartjsScales::setYAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
    ------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
  • Pipeline finished with Skipped
    2 months ago
    #361604
  • πŸ‡ΊπŸ‡ΈUnited States andileco

    Thank you for this huge amount of work. I hope people stop using this version in favor of the 5.x branches, but it's still better to have clean code while there are some users.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024