- First commit to issue fork.
- πΊπΈUnited States andileco
@bluegeek, I see this as "Needs review", but I'm not seeing any changes in the "3144014-fix-code-standards" branch.
- Merge request !121Issue #3144014 by andileco, bluegeek9: Fix code standards errors 8.x-3.x β (Merged) created by bluegeek9
- πΊπΈUnited States bluegeek9
I left these four issues. All the changes in the pull request are whitespace changes.
FILE: /var/www/html/web/modules/custom/charts/modules/charts_chartjs/src/Settings/Chartjs/ChartjsScales.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------ 32 | ERROR | Public method name "ChartjsScales::getXAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps) 42 | ERROR | Public method name "ChartjsScales::setXAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps) 52 | ERROR | Public method name "ChartjsScales::getYAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps) 62 | ERROR | Public method name "ChartjsScales::setYAxes" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps) ------------------------------------------------------------------------------------------------------------------------------------------------------
-
andileco β
committed d7752751 on 8.x-3.x authored by
bluegeek9 β
Issue #3144014 by bluegeek9, andileco: Fix code standards errors 8.x-3.x
-
andileco β
committed d7752751 on 8.x-3.x authored by
bluegeek9 β
- πΊπΈUnited States andileco
Thank you for this huge amount of work. I hope people stop using this version in favor of the 5.x branches, but it's still better to have clean code while there are some users.
Automatically closed - issue fixed for 2 weeks with no activity.