- πΊπΈUnited States jcandan
@kerasai, I was still seeing this issue during my tests of π Doesn't work with multiple phone fields Needs work .
- πΊπΈUnited States jcandan
This is the last holdout for a
rc2
and π Release 2.0.0 Needs review . - πͺπΈSpain plopesc Valladolid
Tested this issue in a 10.4.7 site with both telephone_validation and and telephone_international_widget modules enabled.
Followed the steps to reproduce and I was not able to reproduce the bug under different circumstances.
Attached screen record for reference. https://www.drupal.org/files/issues/2025-05-20/3302638.mp4 β
I think we can mark this issue as fixed. Marking as RTBC for now :)
- πΊπΈUnited States jcandan
In your video, you type the exit code and country code into the field, rather than select the flag. I was able to reproduce this bug by selecting the flag.
- πͺπΈSpain plopesc Valladolid
After some trial and error with @jcandan, we found that the bug only happens if the phone field is not affected during the edit phase.
If the form element validation is triggered, either modifying the value or just focusing the form element, the country code is moved to the textfield and validation works as expected
- Merge request !13Issue #3143446: Flag not selected on node editing form forces user to re-select β (Open) created by plopesc
- Merge request !14Issue #3143446: Flag not selected on node editing form forces user to re-select β (Merged) created by jcandan
- πΊπΈUnited States jcandan
@plopesc, thanks for your work on this.
Your test correctly failed prior to the fix, and passes after the fix. I've refactored a bit, removing the AJAX adjustments and adjusted the conditional logic for persisting the country selection. Feel free to add an issue if you'd like to describe steps to reproduce the AJAX issue your team is experiencing.
MR !14 is ready for review. Will leave this open for a couple days to receive feedback, but this looks good to me.
- πͺπΈSpain plopesc Valladolid
Looks good to me.
Marking as RTBC as this will cover a high percentage of the use cases.Our team will have to use an overridden version of the JS file in any case :)
-
jcandan β
committed 0e554c07 on 2.0.x
Issue #3143446 by jcandan, plopesc, jcmartinez: Flag not selected on...
-
jcandan β
committed 0e554c07 on 2.0.x