Automatically closed - issue fixed for 2 weeks with no activity.
Few outstanding coding standards issue.
❯ drupal-check -ad web/modules/contrib/responsive_favicons
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ---------------------------------------------------------------------
Line responsive_favicons.module
------ ---------------------------------------------------------------------
178 PHPDoc tag @param has invalid value ($file_path
The filename of the icon.): Unexpected token "$file_path", expected
type at offset 61
------ ---------------------------------------------------------------------
------ -------------------------------------------------------------------
Line src/Controller/GetFile.php
------ -------------------------------------------------------------------
43 PHPDoc tag @param has invalid value ($request
a Request object.): Unexpected token "$request", expected type at
offset 78
------ -------------------------------------------------------------------
[ERROR] Found 2 errors
❯ phpcs --standard="Drupal" web/modules/contrib/responsive_favicons
FILE: /Users/marcus/Sites/marcogandi.com/web/modules/contrib/responsive_favicons/src/Controller/GetFile.php
-------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------
21 | ERROR | [ ] Parameter comment must start with a capital letter
22 | ERROR | [x] Separate the @param and @return sections by a blank line.
25 | ERROR | [ ] PHP4 style constructors are not allowed; use "__construct()" instead
40 | ERROR | [ ] Missing parameter type
61 | ERROR | [x] Expected 1 blank line after function; 0 found
62 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------
FILE: /Users/marcus/Sites/marcogandi.com/web/modules/contrib/responsive_favicons/src/Routing/DefaultFavicons.php
-------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
10 | WARNING | [x] Unused use statement
41 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
48 | WARNING | [x] A comma should follow the last multiline array item. Found: ''
61 | ERROR | [x] Expected 1 blank line after function; 0 found
62 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------
❯ phpcs --standard="DrupalPractice" web/modules/contrib/responsive_favicons
FILE: /Users/marcus/Sites/marcogandi.com/web/modules/contrib/responsive_favicons/src/Form/ResponsiveFaviconsAdmin.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------
114 | ERROR | The $_FILES super global must not be accessed directly; inject the request.stack service and use $stack->getCurrentRequest()->files->get('files') instead
137 | WARNING | Variable $field is undefined.
255 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
257 | WARNING | Exceptions should not be translated
-------------------------------------------------------------------------------------------
FILE: /Users/marcus/Sites/marcogandi.com/web/modules/contrib/responsive_favicons/src/Controller/GetFile.php
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
31 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------
Patch will follow up soon.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Automatically closed - issue fixed for 2 weeks with no activity.