- last update
over 1 year ago 4 pass - last update
over 1 year ago 4 pass - Status changed to Needs work
over 1 year ago 1:48pm 3 October 2023 - heddn Nicaragua
-
+++ b/fivestar.module @@ -352,3 +352,25 @@ function template_preprocess_fivestar_summary(array &$variables) { + foreach (['d7_vote_type', 'fivestar_vote_type'] as $provisioned_dep) {Instead of looking for specific named migrations, can we look for migrations that have a source plugin of
fivestar_vote_type? -
+++ b/fivestar.module @@ -352,3 +352,25 @@ function template_preprocess_fivestar_summary(array &$variables) { + $migrations[$plugin_id]['migration_dependencies']['required'][] = $provisioned_dep;Also, instead of using required, can we use optional? Required makes all votes, well, required. And what if we want to filter out a few of the votes? Then the requirement won't be met. Better to influence the order by using optional but not require.
-
+++ b/src/Plugin/migrate/process/FivestarVoteType.php @@ -0,0 +1,33 @@ + $this->configuration['migration'] = ['d7_vote_type'];Let's make this additive in case someone has provided a migration configuration for another migration instead of this specific name.
-
- 🇩🇪Germany marc.bau
RTBC. Migration simply works with the patch (not without) and field is taken over from D7 to D10.