Commas in FAQpage questions and answers produce duplicate name and text

Is there anything still needed for this, now that ✨ Improve support for multi-value schema using Metatag's custom separator option Fixed has been committed?

The problem persists with Metatag 2.0 and Schema Metatag 3.0.1

Thanks for confirming it.

This needs to be rerolled.

We have a WYSIWYG editor (v5) text field containing a text with multiple breaks (br tag). The text is then split in the schema at the br-tags and for each br-tag a text property is inserted.

It looks like this, that even with commas in the text the property is split up

I have to revise my statement. It is only commas and not br tags. Sorry for the disturbance.

I'm not sure I understand it correctly.

But shouldn't the text property also appear in Drupal\schema_metatag\Plugin\metatag\Tag\SchemaNameBase::neverExplode()? And then wouldn't the order of the $explode query in Drupal\schema_metatag\Plugin\metatag\Tag\SchemaNameBase::::processItem() have to be adjusted and checked first for neverExplode() and then for hasSeparator?

    if ($key === 0) {
      $explode = $this->multiple();
    }
    elseif ($this->schemaMetatagManager->hasSeparator()) {
      $explode = TRUE;
    }
    else {
      $explode = !in_array($key, $this->neverExplode());
    }

becomes

    if ($key === 0) {
      $explode = $this->multiple();
    }
    elseif (!in_array($key, $this->neverExplode()) {
      $explode = TRUE;
    }
    else {
      $explode = $this->schemaMetatagManager->hasSeparator();
    }

I am not sure about the type "text". Is it allowed to use it multiple times somewhere?

A quick test with adding "text" to neverExplode() and with the following ruleset at Drupal\schema_metatag\Plugin\metatag\Tag\SchemaNameBase::processItem() fixes the problem:

    switch (true) {
      case $key === 0:
        $explode = $this->multiple();
        break;
      case in_array($key, $this->neverExplode()):
        $explode = FALSE;
        break;
      case !in_array($key, $this->neverExplode()):
        $explode = TRUE;
        break;
      case $this->schemaMetatagManager->hasSeparator():
        $explode = TRUE;
        break;
      default:
        $explode = FALSE;
    }

Out of interest, if you change the Metatag module's delimiter from a comma to something else, does this problem go away?

I have missed this configuration :(
If I set it to something else, the issue is fixed.

Thanks for letting us know.