Improve support for multi-value schema using Metatag's custom separator option

This can be unpostponed now that ✨ Use custom delimiter instead of commas for multiple values Fixed was commited to at least the metatag 2.0.x branch.
The patch #2976935-46: Improve support for multi-value schema using Metatag's custom separator option → worked for me.

This should be added to v3.

Rerolled.

Anyone want to work on test coverage for this?

@DamienMcKenna hello! I can work on some tests. I've done exactly 1 core test so be patient :)

@DamienMcKenna here's an updated patch that includes unit tests for explode().
Based on my understanding, that covers it, but let me know if I should include any more!

Very nice, thank you!

Hi team. What's the status on this issue? For me Patch from #53 is not working: "Could not apply patch! Skipping. The error was: Cannot apply pat ch https://www.drupal.org/files/issues/2023-01-27/schema_metatag-n2 → 976935-53.patch"

That means the patch needs to be rerolled.

How to reroll this patch? Thanks!

Patch #53 still applies to the 3.0.x branch, therefore it doesn't need to be rerolled. You might just need to update your site to use the new 3.0.x branch, until the changes are committed.

Re-created patch for 2.4

Making the latest 3.0.x patch visible.

Committed. Thank you everyone!

Don't know what I'm doing wrong:

Gathering patches for root package.
Removing package drupal/schema_metatag so that it can be re-installed and re-patched.
  - Removing drupal/schema_metatag (2.4.0)
Deleting web/modules/contrib/schema_metatag - deleted
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/schema_metatag (2.4.0): Extracting archive
  - Applying patches for drupal/schema_metatag
    https://www.drupal.org/files/issues/2023-05-25/schema_metatag_2976935_59.patch (Explode Separator)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-05-25/schema_metatag_2976935_59.patch

Generating autoload files
42 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found

composer.json:

	"enable-patching": true,
	"patches": {
		"drupal/schema_metatag": {
			"Explode Separator": "https://www.drupal.org/files/issues/2023-05-25/schema_metatag_2976935_59.patch"
		}
	}

If you want this functionality please update to Schema Metatag 3.0.x-dev and Metatag 2.0.x-dev, or wait until I release the final versions next week.

(fixing the attributions)

Automatically closed - issue fixed for 2 weeks with no activity.