Default sort doesn't work

A real problem exists here. And the arguments of the related issue #3131305: Default Sort Order Not Working → are right,

The Default sort order does not work because the code continually resets the aaSorting to an empty array as it loops over each field, so only the last column could be default sorted.

Should be changed the inside loop code,

    // Set default sort order.
    $datatable_options['aaSorting'] = [];
    if ($options['default'] == $field) {
      $datatable_options['aaSorting'] = [[$position, $options['order']]];
    }

puting $datatable_options['aaSorting'] = []; out of the loop. Enough. Although necessary.

$datatable_options['aaSorting'] is a global information to the table. If no column is chosen as default $options['default'] is set to -1 and never match $field, meaning $datatable_options['aaSorting'] need to be initialized. If a column is chosen (only one since radio button) $options['default'] is set to the corresponding field name and one match exists in the loop.

Also possible the change,
$datatable_options['aaSorting'] = [[$position, $options['order']]];
->
$datatable_options['aaSorting'][] = [$position, $options['order']];
In this way some thing wrong in the $datatable_options['aaSorting'] processing is more visible.

The patch corresponding to #4 for 2.x-dev.

With the right issue number.

Changes LGTM @Chris64. Could you please prepare this as MR?

MR ready.

RTBC for MR!15 - thank you @Chris64. Final test by maintainer.

@Chris64: is the related issue fixed by this patch too? (Extraordinay contribution by the way @Chris64 and @Anybody, I added a credit section for special thanks and listed you both on the project page.)

Merged and queued for upcoming release.

@diqidoq, the related issue #3014926 → is from the 7.x-1.x-dev version, and the code is a little different. But it is the same problem in the code, as noted by @Anybody. This patch does not apply to the 7.x version.

Ah yes, of course... Sorry I missed the different version. Then all is self explanatory. Thanks!

Awesome contributions @Chris64. I'll think already about how to embrace your comittment to the Drupal community. +1

Automatically closed - issue fixed for 2 weeks with no activity.