- Status changed to Needs work
over 1 year ago 6:38pm 15 February 2023 - 🇨🇦Canada NickDickinsonWilde Victoria, BC (T'So-uke lands)
Looks good to me, but does need specific test/assertions.
Problem
When using this module with the Groups module. Adding or creating group content is impossible due to special characters used in the Group Content Enabler add and edit routes (i.e. group/{group_id}/content/create/group_media%3Afile and group/{group_id}/content/create/group_media:file)
These special characters fail a comparison between the path and the request to see if it has already been modified.
Solution
By encoding each part of the string, we can ensure that the special characters are compared correctly.
Needs work
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Looks good to me, but does need specific test/assertions.