FPP lost path context on ajax request

#5 works for me together with the Facets 2.x AJAX fix: https://www.drupal.org/project/facets/issues/3052574#comment-15050142 🐛 Facets with AJAX not working in most of situations Needs work

Automatically closed - issue fixed for 2 weeks with no activity.

With Drupal 10.1 views is using GET AJAX requests by default → , when AJAX is enabled.

In my case we're using views_infinite_scroll and the path context is lost, because of the POST limitation in this commit. I think we would need to make it work with GET requests as well now.

@szeider, if you could kindly share a solution to this, I'll review it.

D10.1-only issue?

Yes, the problem is tied to Drupal 10.1 where the support for AJAX GET requests has been introduced and made the default for example pagination.

It's essentially about this line.

if ($q === NULL && $this->request->isMethod('POST') && !empty($_REQUEST['view_path'])) {

I don't know why the limitation to the method was made, but in my test case changing it to the following resolved the issue

if ($q === NULL && !empty($_REQUEST['view_path'])) {

Thanks @szeidler for mentioning the core changelog and the fix, works for me too. I don't think that removing POST limitation would cause any issue. Here is a patch, it should also apply to 2.0.x branch https://git.drupalcode.org/project/facets_pretty_paths/-/blob/2.0.x/src/...

Removing the `$this->request->isMethod('POST')` check seems like the best approach. We could have checked if `POST or GET request` but I don't see any reason for such limitation.

Tested on one client project and working as expected.

This seems like an important fix.

Would someone be willing to wrap this new condition in a version check?

if (version_compare(\Drupal::VERSION, '10.1', '>=')) {
  // Run the Drupal 10.1+ logic
}
else {
  // Run the original logic.
}

Re done the patch with the additional logic check requested above :)

Automatically closed - issue fixed for 2 weeks with no activity.