Enforce HTTPS

A patch for 2.0.x version.

The previous patch was not compatible with the OpenID connect 3.0.x version. This one is.

#8 works for me. Thanks.

I think getRedirectUrl should have {@inheritdoc} in the function comment, rather than Enforces SSL

Isn't this always a problem that should be solved by the reverse proxy configuration / request handling? Incoming requests should also require HTTPS.

New MR for 2.0.0-beta7 https://git.drupalcode.org/project/openid_connect_windows_aad/-/merge_re...

(yes I've got myself all mixed up with git, sorry about that :))

@Seb_r Look at #10 patch. You didn't include almost any of the changes.

https://www.drupal.org/files/issues/2023-03-21/enforce-https-3124961-2.0... →

Hi @solideogloria,

i know, but the rest of the changes are code style, and i wasn't sure it's the role of that patch to fix them.

It also had

@@ -249,6 +249,7 @@ as the mapping between Azure AD accounts and Drupal users.<br/>
       '#type' => 'item',
       '#markup' => Url::fromRoute('openid_connect_windows_aad.sso', [], [
         'absolute' => TRUE,
+        'https' => TRUE,
         'language' => $this->languageManager->getLanguage(LanguageInterface::LANGCODE_NOT_APPLICABLE),
       ])->toString(),
     ];

Yes sorry,

I pushed it back.

Have a good day,

Seb