- Status changed to RTBC
almost 2 years ago 12:13pm 1 September 2023 - last update
almost 2 years ago 2 pass - π§π¬Bulgaria pfrenssen Sofia
Rerolled so it applies cleanly to 8.x-2.x. No changes made.
- Status changed to Needs review
almost 2 years ago 8:38pm 12 September 2023 - last update
almost 2 years ago 2 pass - πΊπΈUnited States jeffschuler Boulder, Colorado
I had a few issues with this:
$form_state->getTriggeringElement()
often wasn't set when I saved a node (with a tablefield inside a paragraph), so thevalidateTablefield()
function wasn't being run. I removed that conditional from insideformElement()
and changed it to use$form_state->isSubmitted())
insidevalidateTablefield()
.- When the table was reorder-able, the weight element inside the row was being counted as a value, so an empty table was still being saved. So we check for that.
- All sub-fields of the tablefield were being highlighted as the error. I pass the table sub-field to setError(), since that's what we're checking has values.
- Status changed to Needs work
5 months ago 2:40pm 15 February 2025 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Please use an issue fork and merge request.
- πΊπΈUnited States swirt Florida
I created a fork as requested and tried to apply patch #9 but it failed to apply. So I went through it line by line and applied it as closely as possible with what was there.
It has been 5 years since I created this issue and I no longer have access to a codebase that is using it. So I will need to rely on others to test this out.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Re-rolled on 3.0.x. Review and tests by others needed.