The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Assigned to znerol
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:01pm 19 July 2023 - Merge request !4405Issue #3109600: Convert uses of $_SESSION in language module β (Closed) created by znerol
- last update
about 1 year ago 29,822 pass - Status changed to Needs work
about 1 year ago 2:59pm 19 July 2023 - last update
about 1 year ago 29,806 pass, 11 fail - Status changed to Needs review
about 1 year ago 4:33pm 19 July 2023 - last update
about 1 year ago 29,819 pass, 1 fail - last update
about 1 year ago 29,819 pass, 1 fail - π¨πSwitzerland znerol
Looks like π [random test failure] Random failure in PathWorkspacesTest Fixed
- Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Waiting for branch to pass - last update
about 1 year ago 29,822 pass - last update
about 1 year ago 29,822 pass - last update
about 1 year ago 29,822 pass - Status changed to RTBC
about 1 year ago 8:52am 20 July 2023 - π³π±Netherlands daffie
All changes look good to me.
The MR does what the IS states.
For me it is RTBC. - last update
about 1 year ago 29,873 pass - last update
about 1 year ago 29,877 pass 9:22 5:45 Running- last update
about 1 year ago 29,886 pass - last update
about 1 year ago 29,908 pass - last update
about 1 year ago 29,912 pass - last update
about 1 year ago 29,946 pass - last update
about 1 year ago 29,952 pass, 1 fail - last update
about 1 year ago 29,953 pass - last update
about 1 year ago 29,946 pass, 2 fail - last update
about 1 year ago 29,958 pass - last update
about 1 year ago 29,958 pass - last update
about 1 year ago 29,958 pass, 2 fail - last update
about 1 year ago 30,044 pass - last update
about 1 year ago 30,049 pass - last update
about 1 year ago 30,056 pass 9:51 5:42 Running- π³πΏNew Zealand quietone New Zealand
I triaged this RTBC issue β sometime in the last weeks but didn't leave a comment.
I didn't find anything that needed to be done, leaving at RTBC.
- last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,063 pass - last update
about 1 year ago 30,134 pass - last update
about 1 year ago 30,135 pass - last update
about 1 year ago 30,136 pass - last update
about 1 year ago 30,136 pass - last update
12 months ago 30,146 pass - last update
12 months ago 30,146 pass - last update
12 months ago 30,150 pass - Status changed to Needs review
12 months ago 7:22pm 13 September 2023 - πΊπΈUnited States xjm
Thanks folks for working on this. I was frankly shocked we were still messing with
$_SESSION
in this decade.I recognize that this was descoped from a previous issue for reviewability, but why is it being done by module scope? We're not going to see a series of per-module conversions, are we? Is there a reason that the language module is special such that it merits a dedicated issue?
Looking at the parent, I see that there are existing child issues for forms and batch (which is good scope) and
ViewExecutable
(which is reasonable given thatViewExecutable
is "special" for sure). Those seem fine. But is it going to be just those three issues, or more? The total scope of child issues needed should also be documented somewhere that I don't have to hunt for it. :)Anytime we make an exception to the issue scope policy, the issue summary should state why.
If the Language module child issue is a one-off and there's a particular reason for it, the issue can be set back to RTBC with that reason documented. Otherwise, the scoping might need a rethink.
Thanks!
- π¨πSwitzerland znerol
The original issue became too complicated at some point (see #2473875-71: Convert uses of $_SESSION to symfony session retrieved from the request β ). In order to make that one easier to review, I decided to split out the messier ones, so we can track special cases independently. In the meantime the original issue was committed. The remaining patches are small (notable exception is [#2484991) and tightly scoped.
To sum up, there are two open issues (both with a tight scope) to convert remaining references of direct
$_SESSION
superglobal access. Both are RTBC.- π Convert uses of $_SESSION in forms and batch Needs work
- π Convert uses of $_SESSION in language module Needs review (this one)
- Status changed to RTBC
12 months ago 12:40pm 14 September 2023 - π³π±Netherlands daffie
It is maybe not the default way we subclass issues in child issues, but in this instance it is to me the right way to do it. Together with the one for "forms and batch", they are one-off.
Back to RTBC. - πΊπΈUnited States xjm
Thanks @daffie and @znerol!
Saving credits for the feedback and reviews.
- last update
12 months ago 30,158 pass - last update
12 months ago 30,161 pass - last update
12 months ago 30,168 pass - last update
12 months ago 30,168 pass - last update
12 months ago 30,203 pass, 1 fail - last update
12 months ago 30,208 pass - last update
12 months ago 30,350 pass, 2 fail - last update
11 months ago 30,360 pass - last update
11 months ago 30,360 pass - last update
11 months ago 30,371 pass - last update
11 months ago 30,377 pass - Status changed to Fixed
11 months ago 8:15am 6 October 2023 -
alexpott β
committed 36f73503 on 11.x
Issue #3109600 by znerol, andypost, daffie, xjm: Convert uses of $...
-
alexpott β
committed 36f73503 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.