Convert uses of $_SESSION in language module

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased and switched to MR workflow.

Looks like 🐛 [random test failure] Random failure in PathWorkspacesTest Fixed

All changes look good to me.
The MR does what the IS states.
For me it is RTBC.

I triaged this RTBC issue → sometime in the last weeks but didn't leave a comment.

I didn't find anything that needed to be done, leaving at RTBC.

Thanks folks for working on this. I was frankly shocked we were still messing with $_SESSION in this decade.

I recognize that this was descoped from a previous issue for reviewability, but why is it being done by module scope? We're not going to see a series of per-module conversions, are we? Is there a reason that the language module is special such that it merits a dedicated issue?

Looking at the parent, I see that there are existing child issues for forms and batch (which is good scope) and ViewExecutable (which is reasonable given that ViewExecutable is "special" for sure). Those seem fine. But is it going to be just those three issues, or more? The total scope of child issues needed should also be documented somewhere that I don't have to hunt for it. :)

Anytime we make an exception to the issue scope policy, the issue summary should state why.

If the Language module child issue is a one-off and there's a particular reason for it, the issue can be set back to RTBC with that reason documented. Otherwise, the scoping might need a rethink.

Thanks!

The original issue became too complicated at some point (see #2473875-71: Convert uses of $_SESSION to symfony session retrieved from the request → ). In order to make that one easier to review, I decided to split out the messier ones, so we can track special cases independently. In the meantime the original issue was committed. The remaining patches are small (notable exception is [#2484991) and tightly scoped.

To sum up, there are two open issues (both with a tight scope) to convert remaining references of direct $_SESSION superglobal access. Both are RTBC.

• 📌 Convert uses of $_SESSION in forms and batch Needs work
• 📌 Convert uses of $_SESSION in language module Needs review (this one)

It is maybe not the default way we subclass issues in child issues, but in this instance it is to me the right way to do it. Together with the one for "forms and batch", they are one-off.
Back to RTBC.

Thanks @daffie and @znerol!

Saving credits for the feedback and reviews.

Committed 36f7350 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

znerol → closed merge request !4405