This is still an issue in
8.x-2.8
withremote_video
support, it seems like some initial work went into the code but never made it.- Status changed to Needs review
about 1 year ago 1:13pm 8 November 2023 - last update
about 1 year ago 2 pass - ๐ณ๐ดNorway mnlund
Here is a new take on this one, since you still can't use custom media types as for example oembed.
Instead of defining this and guessing, this patch adds all defined Media types to the dialog in the provided Media block in this module.
- last update
about 1 year ago 2 pass - ๐ณ๐ดNorway mnlund
Re-added support for the existing media types guessing as a fallback.
The main point with this patch is to gain more control over which Media types, based on the Media types entity definitions, you can use in the Media block and the Media Component. For example if you are using the Media Component in Gutenberg and pass image as allowed type, all Media types supporting images will be allowed. With this patch you get some more fine grained control and can pass the entity IDs for the Media types you want to allow.
The Media block allows all defined Media types as standard.
Would be nice to see if we can get this reviewed and possibly have it re-rolled against
3.x
- Status changed to Needs work
about 1 year ago 9:52am 19 December 2023 - ๐ณ๐ดNorway eiriksm Norway
Can we get a merge request with this, so the pipelines can run the patch? ๐๏ธ
Also, this needs tests. If you need some kickstart to get an environment for writing tests, here is a repo that should get you going: https://github.com/frontkom/drupal-contrib-ddev
- First commit to issue fork.
- ๐ณ๐ดNorway vegardjo
No tests still, but MR of last patch created โ๏ธ
I noticed a bug in the patch, if you add any other custom media library (non-core ones), the
allowedTypes
gets ignored and it will be loaded regardless of what you define- ๐ธ๐ฆSaudi Arabia martins.bruvelis Thuwal
martins.bruvelis โ made their first commit to this issueโs fork.
- Merge request !154Issue #3107837 patch for version 3.0.x "Cannot add custom type media". โ (Open) created by martins.bruvelis