Fix phpcs errors

Comment 10 months ago →
🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
Status changed to Needs work 8 months ago7:15am 20 August 2024

🇵🇭Philippines cleavinjosh

Hi @sumit.prajapati,

I applied patch #3, it was applied smoothly and fixed some of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  role_specific_user_block git:(8.x-1.0) curl https://www.drupal.org/files/issues/2020-12-24/role_specific_user_block-4210347-3.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2044  100  2044    0     0   6896      0 --:--:-- --:--:-- --:--:--  6905
patching file role_specific_user_block.module
patching file src/Form/RoleSpecificUserBlockSettings.php
➜  role_specific_user_block git:(8.x-1.0) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml role_specific_user_block

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/role_specific_user_block/role_specific_user_block.info.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/role_specific_user_block/src/Form/RoleSpecificUserBlockSettings.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 20 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------------------------------------------------------------------------

Time: 127ms; Memory: 10MB

➜  contrib

Thank you.

Assigned to priyanka_chauhan31
Comment about 1 month ago →
🇮🇳India priyanka_chauhan31 Noida
Comment about 1 month ago →
🇮🇳India priyanka_chauhan31 Noida
Hi, Please review the patch.

Comments & Activities