Make iframe (noscript) optional

Reroll for 8.x-1.6

Thank you. The above patch looks good, applies to current 8.x-1-dev and 8.x-1.6, and works after a cache clear. It it is not suitable for 8.x-2 branch.

The above patch does not work on 8.x-1.7 as google_tag_update_8104() is now declared twice.

Reroll for 8.x-1.7, changing update function name, see #17.

jan kellermann → changed the visibility of the branch 3106318-make-iframe-noscript-optional to hidden.

I created MR for version 2.0.x incl. tests for disabling noscript with iframe.

Please review and feedback.

Thanks for that. I installed it and ran updb (a mistake, I should have uninstalled 1.7 first). So ran drush pmu google_tag, drush en google_tag.

After that I saw an error 'google_tag_container entity missing'.

At the same time my administrator role and all related permissions were deleted. I am not blaming this MR, especially as I had failed to uninstall google_tag 1.7 before proceeding, and I do not really know the cause, so have not set back to 'needs work'. Just now feeling too traumatized to test again.

Happy holidays, thank you for testing! I'm sorry that you had so many problems. However, the errors described are not related to the code from the MR.

I tested the MR and it works great. Makes it possible to be compliant with CMP like Klaro