\Drupal\editor\Ajax\EditorDialogSave::__construct() should typehint as an array instead of a string

Reviewing #37 it appears to be adding the typehint already (array $values) {

Agreed, typehint is there, and what I can see in contrib modules like https://git.drupalcode.org/project/ckeditor5_embedded_content/-/blob/1.0... they are also passing arrays. Testing this patch and the contrib module also continues to work fine + PhpStorm stops complaining about the value as an array not matching the string hint. I believe this can be RTBC.

1. +++ b/core/modules/editor/src/Ajax/EditorDialogSave.php
   @@ -15,17 +15,20 @@ class EditorDialogSave implements CommandInterface {
      protected $values;
   

   Let's add a parameter typehint while we're at it.

2. +++ b/core/modules/editor/src/Ajax/EditorDialogSave.php
   @@ -15,17 +15,20 @@ class EditorDialogSave implements CommandInterface {
   -  public function __construct($values) {
   +  public function __construct(array $values) {
   +    if (!is_array($values)) {
   +      @trigger_error('Calling \Drupal\editor\Ajax\EditorDialogSave::__construct with a non-array $values parameter is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0.', E_USER_DEPRECATED);
   +    }
   

   If we have the typehint then the deprecation is pointless because it will never occur.

   I think in this instance adding the typehint is okay given the earlier comment.

Updated as per feedback in #45. Hiding patches in favour of merge request.

Feedback appears to have been addressed.

Updated the issue summary slightly to use standard template.

Not backported just in case this breaks some strange edge case somewhere, although you are probably doing something wrong if you run into this.

Committed d2d6d0c and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.