The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India nikhil_110
Re-roll patch #10 against Drupal 9.5.x
Patch #10 is not applied for Drupal 9.5.x so Inter-diff file is not added.Checking patch core/modules/file/tests/src/Functional/FileFieldWidgetTest.php... Hunk #1 succeeded at 94 (offset 2 lines). Hunk #2 succeeded at 267 (offset 2 lines). Hunk #3 succeeded at 335 (offset 4 lines). Hunk #4 succeeded at 353 (offset 5 lines). error: while searching for: $this->assertEqual($attacker_user->id(), $node_file->getOwnerId(), 'New file belongs to the attacker.'); // Ensure the file can be downloaded. $this->drupalGet($node_file->createFileUrl()); $this->assertSession()->statusCodeEquals(200); // "Click" the remove button (emulating either a nojs or js submission). error: patch failed: core/modules/file/tests/src/Functional/FileFieldWidgetTest.php:564 error: core/modules/file/tests/src/Functional/FileFieldWidgetTest.php: patch does not apply
- last update
over 2 years ago 30,322 pass - last update
over 2 years ago 29,343 pass - 🇮🇳India mohit_aghera Rajkot
I came across this issue while doing the triage for the bugsmash initiative.
My local setup is based on docker compose and folder structure is like this.
> drupal11/app/core/
Drupal core is cloned inside the core directory. and "app" is the docroot.I tried to run the test outside of core as well as inside core folder.
phpunit -c app/core/ app/core/modules/file/tests/src/Functional/FileFieldWidgetTest.php
phpunit modules/file/tests/src/Functional/FileFieldWidgetTest.php
It ran fine for both the instance.
Do I also need to move file inside another outer directory i.e. something like `example/drupal11/app/core`?