- 🇺🇦Ukraine Belialius Cherkasy
Can confirm that patch works as expected. Very useful functionality.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 117 pass - 🇺🇦Ukraine andriy khomych
Hey Miro Dietiker, it seems this functionality is quite useful.
Do you think we can merge this patch? - 🇬🇧United Kingdom gebiss
Thanks,
Applied patch #7 on Drupal 10.2.3 and it works
- Status changed to RTBC
8 months ago 7:24pm 18 April 2024 - 🇺🇸United States firewaller
Patch #13 (tmgmt-reset-finished-job-button-3094355-9.patch) works for us
- last update
8 months ago 116 pass, 2 fail The last submitted patch, 7: tmgmt-reset-finished-job-button-3094355-7.patch, failed testing. View results →
- First commit to issue fork.
- 🇺🇸United States charginghawk
Thank you for this! I opened an MR with the #13 patch. I also wanted the option to be available in more places, so I added it to more spots as well as job items.
- First commit to issue fork.
- 🇨🇭Switzerland berdir Switzerland
Unsure about this. I see the use case, but so far, we deliberately didn't support this. The behavior is also going to vary between different providers. Providers where you submit data, set up mappings and then check for updates are likely going to be confused by this reset. And it might also be unclear when to use reset vs resubmit.
Maybe it should use a more restrictive permission or its own, so that usage of this is more flexible. Or providers should indicate that they support such a reset?
- 🇺🇸United States firewaller
If there are different use-cases based on setup does it make sense to add config to optionally enable the reset functionality? I'd be concerned about relying on the provider itself since that may be up to the individual site instead.
- 🇺🇸United States firewaller
FYI this patch applies to 8.x-1.17 but introduces a regression when viewing the node's Translation Jobs tab:
Error: Class "Drupal\tmgmt\Entity\ListBuilder\Url" not found in Drupal\tmgmt\Entity\ListBuilder\JobListBuilder->getDefaultOperations() (line 41 of /opt/app-root/src/web/modules/contrib/tmgmt/src/Entity/ListBuilder/JobListBuilder.php).
I will reroll a new patch.