Add manage display UI for aggregator items

Created on 27 October 2019, over 5 years ago
Updated 2 July 2024, 9 months ago

1) Looking at the code in Drupal\aggregator\Entity\Item, several fields have called setDisplayConfigurable('view', TRUE). However there is no "Manage Display" page in the GUI to configure these fields - the annotation has no entry for field_ui_base_route.

Note that "Manage Form Display" and "Manage Fields" would not make sense for aggregator item - only "Manage Display" is wanted.

2) The default configuration is missing for core.entity_view_display.aggregator_feed.aggregator_item.default.

✨ Feature request
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom adamps

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    I started looking into this and I quickly found that without defining a field_ui_base_route, which automatically pulls in manage fields and manage form display, layout builder quickly throws exceptions instead of handling errors. Additionally, layout builder will continue to throw exceptions if the form display routes are removed.

    So in the end as I was playing around with this, I needed to also alter local tasks to hide the manage form display and manage fields, as well as adding a dummy route that redirects to manage display when field_ui is enabled.

    It's kind of a hack and pretty much all due to Layout Builder.

    I'll create a work-in-progress issue fork and branch shortly.

    I also found that the display options configured in Item need work. If a field display options are defined, then warnings will be thrown because of type and label keys.

  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA
  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    I'm going to guess this should have tests for when field_ui and layout_builder are enabled respectively.

  • Pipeline finished with Failed
    29 days ago
    Total: 384s
    #441508
  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    I was thinking this over, and I thought "why fight it?" Maybe aggregator items should provide a Manage Fields and Manage Form Display route even if they are not used by default. It might make it easier to extend aggregator functionality dealing with description property in case someone wanted to store other metadata from a feed.

    Adding a warning message to Manage Fields and Manage Form Display to indicate advanced / non-default usage would be important to not confuse default users.

    Optionally, an additional setting could be added to show/hide the pages would help. Since altering the routes would still be fighting Layout Builder, maybe just hide the local tasks.

  • Pipeline finished with Failed
    20 days ago
    Total: 196s
    #448424
  • Pipeline finished with Failed
    20 days ago
    Total: 203s
    #448430
  • Pipeline finished with Failed
    20 days ago
    Total: 273s
    #448455
  • Pipeline finished with Failed
    20 days ago
    Total: 205s
    #448461
Production build 0.71.5 2024