Potential caching issue when modifying the mobile menu with hooks

In my case adding the cache context to $build had no effect.

I had to it in the $rendered_tree["#cache"]["contexts"][] = 'user';

Raveen Thakur → made their first commit to this issue’s fork.

If you add the user cache context then the rendered_tree cache will vary per user which might not be what you want. It pretty much makes the page uncacheable for logged in users.

Unfortunately, that's really what I need, at least until the horrible idea of adding a block to the menu tree that varies by user is refactored.

Thanks for the alert!

Once I added patch #14 it was also necessary to add:

/**
 * Implements hook_responsive_menu_off_canvas_tree_prebuild().
 */
function mymodule_responsive_menu_off_canvas_tree_prebuild(array &$build) {
  $build['#cache']['contexts'][] = 'subsite_context';
}

After doing this, I had no more issues with cache.