Contrib.social

Not working for Entity Browser in modals

Open on Drupal.org →
Created on 7 October 2019, over 5 years ago
Updated 14 March 2023, almost 2 years ago

Thank you for this module - very nice work!

I'm having 1 issue: I'm displaying an Entity Browser → in a modal. The entity browser content is displayed in an iframe. I don't want it to look like its an iframe (eg. in-page scrollbar). Unfortunately, I tried using iFrame Resizer but it's not kicking in.

In debugging, I noticed it does work when changing
$(selector, context).iFrameResize(options);
to
$(selector).iFrameResize(options);

I know it's better to limit the behavior to the context, however iFrame Resizer has a system in place in that it's never applied to an element a second time. Eg. the warning message:
[iFrameSizer][Host page: entity_browser_iframe_image] Ignored iFrame, already setup.

Wondering what your thought is?

🐛 Bug report
Status

Postponed: needs info

Version

2.0

Component

Code

Created by

🇧🇪Belgium rp7

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇩🇪Germany Anybody Porta Westfalica
  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇩🇪Germany Grevil

    Patch #2 will not suffice, as removing "context", will lead to Drupal scanning the entire document for each Ajax call, instead of just the relevant context.

  • Issue was unassigned.
  • Status changed to Postponed: needs info almost 2 years ago
  • Comment almost 2 years ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks @Grevil I agree the patch makes things worse, not better. Someone has to check in detail, what's going wrong. The module code seems correct, while the patch seems incorrect.

    Let's change this into a minor bug report in combination with entity browser. The issue may also be at entity_browser and not here.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024