[meta] Convert some tests to Build tests

Just a reroll. And type to run just the Build tests.

I should have known that would not work.

The last submitted patch, 41: 3082230-41.patch, failed testing. View results →

I noticed that other quickstart tests are checking the sqlite version, so I copied that code block to these tests. Also, updated version numbers.

Local testing isn't working for me because I use a personal git hook and that causes failures for chmod. I haven't looked closely but it may be because it is a symbolic link.

The last submitted patch, 43: 3082230-43.patch, failed testing. View results →

I don't know why this is failing with

1) Drupal\BuildTests\Update\UpdateSiteDrushTest::testSiteUpdateWithDrush with data set "12.x" ('drush/drush:12.x')
Failed asserting that ' You are about to:\n
 * Create a sites/default/settings.php file\n
 * CREATE the 'db.sqlite' database.\n
\n
 // Do you want to continue?: yes.                                              \n
\n
' contains "Installation complete.".

what it should be non-interactive, $this->executeCommand('drush site-install --db-url=sqlite://db.sqlite -y');.

Show the error output using an assert.

The last submitted patch, 46: 3082230-46.patch, failed testing. View results →

Well, that is a different error than what I get locally.

The last submitted patch, 48: 3082230-48.patch, failed testing. View results →

Moved past that error and on to a new one.

1) Drupal\BuildTests\Update\UpdateSiteDrushTest::testSiteUpdateWithDrush with data set "12.x" ('drush/drush:12.x')
COMMAND: drush updb -y
OUTPUT:
ERROR: PHP Fatal error:  Declaration of Drush\Command\DrushInputAdapter::getFirstArgument() must be compatible with Symfony\Component\Console\Input\InputInterface::getFirstArgument(): ?string in phar:///usr/local/bin/drush/lib/Drush/Command/DrushInputAdapter.php on line 54
Drush command terminated abnormally due to an unrecoverable error.   �[31;40m�[1m[error]�[0m
Error: Declaration of
Drush\Command\DrushInputAdapter::getFirstArgument() must be
compatible with
Symfony\Component\Console\Input\InputInterface::getFirstArgument():
?string in
phar:///usr/local/bin/drush/lib/Drush/Command/DrushInputAdapter.php,
line 54

Should it not be using vendor/bin/drush?

DrushInputAdapter was Removed from Drush in 2017.

I moved the Drush test to 📌 Add BuildTest for testing update using Drush Active , with links to the core ideas issue about adding drush.
And the quickstart tests to 📌 Add BuildTest for testing Quickstart install and update Needs work

I think Drupal\Tests\Scripts\TestSiteApplicationTest is covered by 🐛 TestSiteApplicationTest requires a database despite being a unit test Needs work

Changing to active because the patches have moved to other issues.

+++ b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
@@ -155,7 +155,6 @@ abstract class BuildTestBase extends TestCase {
-    $this->phpFinder = new PhpExecutableFinder();

This is the only change that is not yet in another issue. This currently an unused property.

And there is #2984031: Create Build Tests For Composer and Drupal →